potiuk commented on PR #427: URL: https://github.com/apache/jackrabbit-filevault/pull/427#issuecomment-5141644486
Ah .. Sorry for that. This is really the part that is variable for repository. Yes token usage is a concern. * We check for rat checks in repo and regular other licence checks - and if the PR fails licence checks, we add the licence * New RAT 0.18.0 allows to use short version (SPDX) of licence - especially in case those AGENTS.md are also excluded during the source code package preparation. * There is an ongoing debate [1] whether short version of licence is acceptable for released source packages (and what form it should be) - and there are different opinions, but I think there is a consensus that whatever unambigious form of licence is added in non-source-package-released repo it is fine. In this case - no licence was added because the PR did not fail so my automation did not try to see which header to add :( . But I am happy to do a follow up - unless you are happy with what you have now ;), Just let me know which option is good for you: a) Full ASF licence b) SPDX, short licence - non-controversial if you also exclude the AGENTS.md from your release source package ``` <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> ``` This is the shortest non-ambigious way I found and this is for example what we use in Airflow (and we exclude the AGENTS.md from released sources via .gitattributes https://github.com/apache/airflow/blob/main/.gitattributes But also - depending on how you do your check, it might also need to add exclusions elsewhere in your pipeline (usually I find it out while raising PR - because PR fails with error :D. More details: [1] https://issues.apache.org/jira/browse/LEGAL-733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
