Copilot commented on code in PR #434:
URL:
https://github.com/apache/jackrabbit-filevault/pull/434#discussion_r4121661817
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java:
##########
@@ -322,22 +322,17 @@ protected VaultPackage getPackage(boolean
forceFileArchive) throws RepositoryExc
}
} else {
File tmpFile = File.createTempFile("vaultpack", ".zip");
Review Comment:
Removing the `deleteOnExit()` fallback here leaves the package temp file
behind when the package remains strongly reachable until JVM shutdown.
`CloseWatcher` only handles archives that become unclosed/GC-observable, so it
cannot cover that case; retain `deleteOnExit()` as a final shutdown fallback in
addition to watcher cleanup.
This issue also appears on line 325 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
