Copilot commented on code in PR #435: URL: https://github.com/apache/jackrabbit-filevault/pull/435#discussion_r4210597512
########## vault-validation/bnd.bnd: ########## @@ -14,9 +14,11 @@ # limitations under the License. # include complete packages (all transitive dependencies lead to Import-Package instructions) --conditionalpackage: org.apache.jackrabbit.jcr2spi.*,org.apache.jackrabbit.vault.fs.spi.impl.jcr20 +-conditionalpackage: org.apache.jackrabbit.jcr2spi.*,org.apache.jackrabbit.vault.fs.spi.impl.jcr20,org.apache.commons.xml.secure.* # only include individual classes from other impl packages -includeresource: @org.apache.jackrabbit.vault-*.jar!/org/apache/jackrabbit/vault/packaging/impl/(DefaultPackageProperties|PackagePropertiesImpl).* -Import-Package: org.apache.felix.cm.*;resolution:=optional, * \ No newline at end of file +<!-- The negation drops the JDK-internal package bnd infers from the reflective Java 8 fallback in HardeningXMLInputFactory.newDefaultFactory(). --> +Import-Package: !com.sun.xml.internal.stream, Review Comment: Add a trailing backslash to continue `Import-Package`. Without it, bnd reads only `!com.sun.xml.internal.stream,`; the Felix clause and wildcard below become a separate property. This drops vault-validation's normal dependency imports. Unlike vault-core, this bundle has no dynamic-import fallback, so loading classes that reference external packages such as the vault-core API fails in OSGi. ########## vault-core/bnd.bnd: ########## @@ -13,18 +13,19 @@ # See the License for the specific language governing permissions and # limitations under the License. -Import-Package: org.apache.jackrabbit.spi2dav;resolution:=optional,\ - org.apache.sling.jcr.api;resolution:=optional,\ - * +<!-- The negation drops the JDK-internal package bnd infers from the reflective Java 8 fallback in HardeningXMLInputFactory.newDefaultFactory(). --> +Import-Package: !com.sun.xml.internal.stream, Review Comment: Add a trailing backslash to continue `Import-Package`. Without it, bnd reads only `!com.sun.xml.internal.stream,`; the optional clauses and wildcard below become a separate property. This drops vault-core's normal static dependency imports, leaving dependency wiring to `DynamicImport-Package: *` without the generated static imports' version constraints. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
