[ 
https://jira.codehaus.org/browse/JBEHAVE-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi resolved JBEHAVE-779.
----------------------------------

    Resolution: Fixed

Constructors in ExamplesTable and ExamplesTableFactory reinstated.  Thanks for 
heads up.
                
> Change of ExamplesTableFactory constructor in patch release
> -----------------------------------------------------------
>
>                 Key: JBEHAVE-779
>                 URL: https://jira.codehaus.org/browse/JBEHAVE-779
>             Project: JBehave
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.6.4, 3.6.5
>            Reporter: Daniel Schneller
>            Priority: Minor
>             Fix For: 3.6.6
>
>
> With JBEHAVE-718 the constructor 
>     public ExamplesTableFactory(Keywords keywords, ResourceLoader 
> resourceLoader,
>             ParameterConverters parameterConverters)
> was changed to
>     public ExamplesTableFactory(Keywords keywords, ResourceLoader 
> resourceLoader,
>             ParameterConverters parameterConverters, TableTransformers 
> tableTranformers)
> when the TableTransformers feature was introduced.
> This is a backwards incompatible change and should not have been included 
> like that in a patch revision with only the last digit of the version number 
> changed, as it breaks existing code (including mine :)) when going up to the 
> latest 3.6 version.
> I suggest adding back the original constructor with a sensible default 
> behavior.
> A pull request on GitHub will be sent: 
> https://github.com/jbehave/jbehave-core/pull/31

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to