@andreaturli @nacx given the error which comes back from the server (a weird 
one, only for a few guests):

    jclouds.headers: << HTTP/1.1 500 Internal Server Error
    jclouds.wire: << "{"error":"Your order has a duplicate price for category 
\"Hardware & Software 
Firewalls\".","code":"SoftLayer_Exception_Order_Item_Duplicate"}"

the softlayer server is behaving badly with this particular guest VM.  i don't 
think we should expect it to sort itself out with a retry.  (unless we want to 
retry until softlayer fix the underlying cause, which could be years!)

so my sense (weakly) is that throwing the exception is the right behaviour for 
the API method, and for callers to handle as appropriate.  in the case here, of 
getting the image for the purpose of node metadata, catching the exception and 
returning null seems reasonable -- meaning that the image is not available for 
some reason).

in short i think andrea's patch is the best solution in this case, unless there 
is a very different pattern we want to follow (cf `Optional`...).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/199#issuecomment-28224912

Reply via email to