> @@ -136,6 +144,23 @@ public void streamManyPagesOfMessages() throws Exception
> {
> }
>
> @Test(dependsOnMethods = { "streamManyPagesOfMessages" })
> + public void listMessagesByIds() throws Exception {
> + for (String zoneId : api.getConfiguredZones()) {
> + MessageApi messageApi = api.getMessageApiForZoneAndQueue(zoneId,
> "jclouds-test");
> + UUID clientId =
> UUID.fromString("3381af92-2b9e-11e3-b191-71861300734c");
> +
> + List<Message> messages = messageApi.list(clientId,
> messageIds.get(zoneId));
> +
> + assertEquals(messages.size(), 4);
> +
> + for (Message message: messages) {
> + assertNotNull(message.getId());
> + assertNotNull(message.getBody());
Just more code to maintain. A test code is so boilerplate that everybody
usually just copy/pastes the method before and makes some changes. It's easy to
miss these "comments" when doing so. And ultimately we'd have to have to look
up the line number anyway to _really_ figure out what went wrong.
If you can convince dev@jclouds that we need to be doing this everywhere, I
think you know my opinion on it ;) , then I'll go along.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/57/files#r7882245
