>We're converting strings to numeric types with valueOf in many places and 
>assuming that the string value is indeed a valid number string. Is that as 
>intended?

Yes, all parsed values are values returned from the corresponding APIs, which 
return primitive ints.

>There's a bunch of "stop-the-IDE-from-reformatting" comments (// at the end of 
>the line) in the code. I don't find them too bad, but would be good to hear 
>how @everett-toews feels about that.

I don't have an strong opinion on this, so we'll remove them.

Thanks for the initial review! Will address the comments

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/49#issuecomment-33236818

Reply via email to