> +         writeLengthFirst("ssh-dss".getBytes(), out);
> +         writeLengthFirst(p.toByteArray(), out);
> +         writeLengthFirst(q.toByteArray(), out);
> +         writeLengthFirst(g.toByteArray(), out);
> +         writeLengthFirst(y.toByteArray(), out);
> +         return out.toByteArray();
> +      } catch (IOException e) {
> +         throw propagate(e);
> +      }
> +   }
> +
> +   /**
> +    * @see SshKeys
> +    */
> +   // http://www.ietf.org/rfc/rfc4253.txt
> +   private static byte[] readLengthFirst(InputStream in) throws IOException {

I'm sure the name makes sense to you, but I first thought you'd be getting back 
a numeric value here. So perhaps just `readString`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/49/files#r9166334

Reply via email to