Thanks for the feedback Andrew. Those test don't use the PATCH method, so we can assume the version bump is not breaking anything. Regarding the 2.0.0-RC2 version questions, it was just me being curious :) I'll open an improvement to update it!
Thanks! I. On 19 June 2014 14:25, Andrew Gaul <g...@apache.org> wrote: > On Thu, Jun 19, 2014 at 09:43:49AM +0200, Ignasi Barrera wrote: >> Thanks for keeping this up to date Andrew! Just a couple considerations: >> >> * The "okhttp.version" property is also used in the OkHttp driver. Could >> you run the openstack-marconi live tests (or the rackspace-cloudqueues >> ones)? Marconi uses the OkHttp driver by default to be able to send PATCH >> requests. Just want to make sure the version bump is not breaking anything. > > I see the same failed tests before and after upgrading with: > > mvn integration-test -pl rackspace-cloudqueues-us -Plive \ > -Dtest.rackspace-cloudqueues-us.identity="${JCLOUDS_IDENTITY}" \ > -Dtest.rackspace-cloudqueues-us.credential="${JCLOUDS_CREDENTIAL}" > > Failed tests: > CloudQueuesUSQueueApiLiveTest>QueueApiLiveTest.listZeroPagesOfQueues:47 > expected [true] but found [false] > > CloudQueuesUSMessageApiLiveTest>MessageApiLiveTest.streamZeroPagesOfMessages:64 > expected [true] but found [false] > > All tests succeed against 1.7.x; Everett can you investigate these failures? > >> * Have you tried (or could you try, if not) upgrading to the latest >> 2.0.0-RC2? > > Sorry, I have not tested this and my limited experience with OkHttp does > not give me confidence in upgrading to a release candidate. This commit > addresses an OutOfMemoryError seen with large payloads in Glacier tests > and a pending pull request removes a stale dependency on an older > mockwebserver artifact. > >> Thanks! >> >> I. >> El 19/06/2014 04:50, <g...@apache.org> escribió: >> >> > Repository: jclouds >> > Updated Branches: >> > refs/heads/master 1982626cd -> ad56db2a4 >> > >> > >> > Upgrade to OkHttp 1.6.0 >> > >> > This upgrades both drivers/okhttp and mockwebserver. Changelog: >> > >> > https://github.com/square/okhttp/blob/master/CHANGELOG.md >> > >> > >> > Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo >> > Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a >> > Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a >> > Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a >> > >> > Branch: refs/heads/master >> > Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e >> > Parents: 1982626 >> > Author: Andrew Gaul <g...@apache.org> >> > Authored: Wed Jun 18 19:41:46 2014 -0700 >> > Committer: Andrew Gaul <g...@apache.org> >> > Committed: Wed Jun 18 19:49:50 2014 -0700 >> > >> > ---------------------------------------------------------------------- >> > project/pom.xml | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > ---------------------------------------------------------------------- >> > >> > >> > >> > http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.xml >> > ---------------------------------------------------------------------- >> > diff --git a/project/pom.xml b/project/pom.xml >> > index 2d3b651..4b259d0 100644 >> > --- a/project/pom.xml >> > +++ b/project/pom.xml >> > @@ -201,7 +201,7 @@ >> > >> > >> > <jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jclouds.test.listener> >> > <test.ssh.keyfile /> >> > >> > >> > <sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor> >> > - <okhttp.version>1.3.0</okhttp.version> >> > + <okhttp.version>1.6.0</okhttp.version> >> > <surefire.version>2.17</surefire.version> >> > </properties> >> > >> > >> > > > -- > Andrew Gaul > http://gaul.org/