> +              .location(location)
> +              .name(input.getMachineType().getName())
> +              .hypervisor("kvm")
> +              .processor(new 
> Processor(input.getMachineType().getGuestCpus(), 1.0))
> +              .providerId(input.getMachineType().getId())
> +              .ram(input.getMachineType().getMemoryMb())
> +              .uri(input.getMachineType().getSelfLink())
> +              .userMetadata(ImmutableMap.of("imageSpaceGb", 
> Integer.toString(input.getMachineType().getImageSpaceGb())))
> +              .volumes(collectVolumes(input.getMachineType()))
> +              .build();
> +   }
> +
> +   private Iterable<Volume> collectVolumes(MachineType input) {
> +      ImmutableSet.Builder<Volume> volumes = ImmutableSet.builder();
> +      for (MachineType.ScratchDisk disk : input.getScratchDisks()) {
> +         volumes.add(new VolumeImpl(null, Volume.Type.LOCAL, new 
> Integer(disk.getDiskGb()).floatValue(), null, true,

`new VolumeImpl`? No builder or other factory for this?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/16/files#r5362360

Reply via email to