Note - this is the work in progress, it's not entirely complete (namely, it needs the expect and live tests for the extension) but I wanted to throw it up to get eyeballs on it. Final version will be squashed/repushed when ready. You can merge this Pull Request by running:
git pull https://github.com/abayer/jclouds-labs-google sg-ext-gce Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/5 -- Commit Summary -- * First chunk of work - got the converters, but need to add tests for them. * First chunk of tests work * Adding the mapping/creating/etc * Adding the mapping/creating/etc * More working tests * Added extension and predicates to support it. And predicate tests. Still need extension tests. -- File Changes -- M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/config/GoogleComputeEngineServiceContextModule.java (31) A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/extensions/GoogleComputeEngineSecurityGroupExtension.java (329) A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/FirewallToIpPermission.java (89) A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/NetworkToSecurityGroup.java (84) A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/loaders/FindNetworkOrCreate.java (65) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/CreateNodesWithGroupEncodedIntoNameThenAddToSet.java (34) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineParserModule.java (5) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Firewall.java (42) A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/internal/NetworkAndAddressRange.java (91) A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/CreateNetworkIfNeeded.java (101) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/predicates/GlobalOperationDonePredicate.java (2) A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/predicates/NetworkFirewallPredicates.java (123) A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/FirewallToIpPermissionTest.java (93) A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/NetworkToSecurityGroupTest.java (94) A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/loaders/FindNetworkOrCreateTest.java (144) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/FirewallApiExpectTest.java (8) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/FirewallApiLiveTest.java (14) A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/functions/CreateNetworkIfNeededTest.java (133) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseFirewallListTest.java (3) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseFirewallTest.java (9) A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/predicates/NetworkFirewallPredicatesTest.java (162) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/5.patch https://github.com/jclouds/jclouds-labs-google/pull/5.diff
