> +
> +   private Iterable<Payload> doSlice(byte[] rawContent, ContentMetadata 
> meta) {
> +      return doSlice(new ByteArrayInputStream(rawContent), meta);
> +   }
> +
> +   private Iterable<Payload> doSlice(File rawContent, ContentMetadata meta) {
> +      try {
> +         return doSlice(new FileInputStream(rawContent), meta);
> +      } catch (FileNotFoundException e) {
> +         throw Throwables.propagate(e);
> +      }
> +   }
> +
> +   private Iterable<Payload> doSlice(InputStream rawContent, ContentMetadata 
> meta) {
> +      return new PayloadIterator(rawContent, meta);
> +   }

Could all the doSlice methods be static? Also, make them `protected` so they 
can be overridden?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/192/files#r7291657

Reply via email to