> + checkState(!operation.get().getHttpError().isPresent(), "Could not
> create firewall, operation failed" + operation);
> +
> + return getSecurityGroupById(group.getId());
> + }
> +
> + @Override
> + public SecurityGroup addIpPermission(IpProtocol protocol, int startPort,
> int endPort,
> + Multimap<String,String> tenantIdGroupNamePairs, Iterable<String>
> ipRanges,
> + Iterable<String> groupIds, SecurityGroup group) {
> +
> + IpPermission.Builder permBuilder = IpPermission.builder();
> + permBuilder.ipProtocol(protocol);
> + permBuilder.fromPort(startPort);
> + permBuilder.toPort(endPort);
> + permBuilder.groupIds(groupIds);
> + permBuilder.cidrBlocks(ipRanges);
I think we had this somewhere else...rename params to match Builder methods
(i.e. `ipRanges` -> `cidrBlocks` here)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/5/files#r7379901
