On 15/01/14 23:31, Ian Dickinson wrote:
I've added the README, and committed all of the recent changes to the
version in Experimental (thanks Rob!). Is there anything remaining
blocking moving the code back to trunk?
I don't see anything.
I had a quick look for "openjena". The only occurrence that looks odd
to me is plugin groupId in demo/pom.xml : not a blocker.
Andy
Ian
On Wed, Jan 15, 2014 at 4:13 PM, Ian Dickinson <[email protected]> wrote:
On Wed, Jan 15, 2014 at 3:47 PM, Andy Seaborne <[email protected]> wrote:
On 15/01/14 15:21, Ian Dickinson wrote:
Oh, and I've added a copy of the LICENSE file from the main project.
I'm not sure what else I need to put in there - do I need to
acknowledge the contribution from Shane St Clair that was submitted
via Jira?
Do either of the the top-level LICENCE or NOTICE files need to change to
reflect dependencies of jena-maven-tools? These need to cover everything in
trunk and ideally the project.
Not as far as I can tell. The only source code we distribute is
licensed under the Apache license. There are dependencies in the
pom.xml related to the process of running a Maven plugin, but we do
not distribute any of those dependencies (they will be pulled in, as
necessary, when the end user runs that Maven target).
See
http://www.apache.org/legal/3party.html
esp category B
dependency:tree -->
+- org.apache.maven:maven-plugin-api:jar:3.1.1:compile
| +- org.apache.maven:maven-model:jar:3.1.1:compile
| \- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M5:compile
| +- javax.enterprise:cdi-api:jar:1.0:compile
| | +- javax.annotation:jsr250-api:jar:1.0:compile
| | \- javax.inject:javax.inject:jar:1:compile
| +- com.google.guava:guava:jar:10.0.1:compile
| | \- com.google.code.findbugs:jsr305:jar:1.3.9:compile
| +- org.sonatype.sisu:sisu-guice:jar:no_aop:3.1.0:compile
| | \- aopalliance:aopalliance:jar:1.0:compile
| +- org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.0.0.M5:compile
| +- org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
| \- org.codehaus.plexus:plexus-classworlds:jar:2.4:compile
org.eclipse.sisu caught my attention and there are others that I don't know
the status of. At that point I didn't know enough to sort it out at the
time.
As far as I can tell, the Sisu dependencies are related to running
certain kinds of Maven plugins, such as for OSGi. Since we don't
depend on that capability, I have excluded the dependency and
everything seems to be working OK. The revised dependency tree is:
$ mvn dependency:tree
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Jena plugins for Apache Maven,including schemagen 0.4-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ jena-maven-tools ---
[INFO] org.apache.jena:jena-maven-tools:maven-plugin:0.4-SNAPSHOT
[INFO] +-
org.apache.maven.plugin-tools:maven-plugin-annotations:jar:3.2:provided
[INFO] | \- org.apache.maven:maven-artifact:jar:3.0:compile
[INFO] +- org.apache.maven:maven-plugin-api:jar:3.1.1:compile
[INFO] | \- org.apache.maven:maven-model:jar:3.1.1:compile
[INFO] +- org.apache.jena:jena-core:jar:2.11.1-SNAPSHOT:compile
[INFO] | +- org.apache.jena:jena-iri:jar:1.0.1-SNAPSHOT:compile
[INFO] | \- xerces:xercesImpl:jar:2.11.0:compile
[INFO] | \- xml-apis:xml-apis:jar:1.4.01:compile
[INFO] +- org.codehaus.plexus:plexus-utils:jar:3.0.15:compile
[INFO] +- junit:junit:jar:4.8.1:compile
[INFO] +- org.apache.maven.shared:maven-verifier:jar:1.2:compile
[INFO] +- org.slf4j:slf4j-api:jar:1.6.4:compile
[INFO] +- org.slf4j:slf4j-log4j12:jar:1.6.4:compile
[INFO] \- log4j:log4j:jar:1.2.16:compile
There's nothing there that I can see that's not (a) already a Jena
dependency, or (b) an Apache product.
Acknowledgements are different - common ways include putting in a README,
ReleaseNotes or ACKNOWLEDGEMENTS file for the module.
I'll add a README.
Ian
