[
https://issues.apache.org/jira/browse/JENA-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884051#comment-13884051
]
Andy Seaborne commented on JENA-628:
------------------------------------
Good catch. I've done some refactoring which is unrelated to the better
placement around BGPs. There functions in this class that are called from TDB,
which needs to control the order of optimization steps at a detailed level.
(And also used in "[quack|http://github.com/afs/quack]"; which is a rewrite the
TDB executor to be better/more general/cleaner.)
> TransformFilterPlacement does not always push down through assign/extend when
> it could
> --------------------------------------------------------------------------------------
>
> Key: JENA-628
> URL: https://issues.apache.org/jira/browse/JENA-628
> Project: Apache Jena
> Issue Type: Bug
> Components: ARQ
> Affects Versions: Jena 2.11.1
> Reporter: Rob Vesse
> Fix For: Jena 2.11.2
>
>
> I've noticed a bug in the improved TransformFilterPlacement where it doesn't
> always do the correct thing when pushing through assign/extend in cases where
> the placement into BGPs is disabled.
> Consider the following example algebra:
> {noformat}
> (filter (= ?x 123) (assign ((?z 123)) (bgp (?s ?p ?x)) ))
> {noformat}
> With optFilterPlacementBGP enabled this produces the following improved
> algebra:
> {noformat}
> (assign ((?z 123)) (filter (= ?x 123) (bgp (?s ?p ?x)) ))
> {noformat}
> However with optFilterPlacementBGP disabled this leaves the algebra as is
> even though it could safely push it through the bind without pushing it into
> the BGP itself.
> I think the fix for this is trivial and I will apply it shortly. I will also
> look and see if there are other cases where it fails to push down as far as
> it could.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
