GitHub user stain opened a pull request:
https://github.com/apache/jena/pull/48
JENA-901 Use Guava for cache, shadowed in jena-core
In comparison with #47, this shadows Guava directly in `jena-core` without
introducing `jena-shadowed-ext`.
This is thus acceptable as a patch-version update - but at the downside
that `jena-core` have to do
import com.google.common.cache.Cache
directly - while all other Jena modules would have to use
import org.apache.jena.impl.ext.com.google.common.cache.Cache
as it is shadowed with the JAR. This will cause problems in the other
modules in an Eclipse-like environment, as the IDE will re-expose com.google
version if `jena-core` is open - and they would then seemingly not be able to
find the `oaj.impl.ext.*` version as that only exist in the Maven-built JAR.
In this scenario, it would probably be cleaner for the other modules to
also shadow guava - in addition to the space-wastage, this probably becomes a
bit awkward - it also means you can't pass any Guava structures between Jena
modules.
One advantage however is that if they all shadow individually, then they
can shadow with the
[minimizeJar](https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#minimizeJar)
option to only get the few Guava classes used (e.g. in jena-core only the
Cache).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stain/jena JENA-901-guava-only-jenacore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit fa020df5320ec2aaaeec29aa568352bca5022347
Author: Stian Soiland-Reyes <[email protected]>
Date: 2015-03-21T02:51:28Z
JENA-901 Use Guava for cache, shadowed in jena-core
this avoids adding a new module, so this is acceptable
as a patch-version update.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
