Github user afs commented on the pull request:
https://github.com/apache/jena/pull/56#issuecomment-99120861
The vast majority of the PR looks good including converting code "in
passing". MultiMap?mulitSet are unlikely to have leaked (and can be restored if
need be); I've already converted my own code elsewhere not to use them.
Where NodeTransform is located is relatively minor - it's not just in
"optimize" as the engine to replace nodes by other nodes is used elsewhere
(e.g. update, few other places). Other systems may have used it where it is for
their own optimizer operations so its a balance of impedance to adopting Jena3
compared to where might go NodeTransform, NodeTransformLib and NodeTransformOp.
While such cases are not going to be numerous, they already have the most work
to do to migrate.
In other words, I'd class it as "minor" and concentrate on other things but
that's just my personal take. The sooner we can get to a sufficiently stable
version to start basing a release on the better - no "second system" effect, or
"third system" effect in this case - and keeping the migration work down
encourages users to migrate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
