Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/57#discussion_r29938058
  
    --- Diff: 
jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java ---
    @@ -33,7 +33,7 @@
     
         /** Create a null cache */
         public static <Key, Value> Cache<Key, Value> createNullCache() {
    -        return new Cache0<>() ;
    +        return new CacheGuava<>(0) ;
         }
    --- End diff --
    
    Cache0 is really just a "complete the set" implementation.  If any use as a 
dummy, the weight of CacheGuava might not be worth it.  Proposal: just remove 
Cache0 (it does not fit with getOrFill anyway).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to