Github user osma commented on the pull request:
https://github.com/apache/jena/pull/64#issuecomment-102406631
> TextIndexConfiguration should be about : analyzer, queryAnalyzer,
multilingual,.. and graphField, langField concern EntityDefinition no ?
> Moreover, to avoid the same growing constructors, EntityDefinition should
be configurable with setters/getters.
Oh yes, sorry, I was a bit confused about TextIndexFactory methods vs.
EntityDefinition. Indeed the field-specific configuration belongs in
EntityDefinition and I agree it would make sense to add setters there instead
of yet more constructors.
As it turns out the TextIndexConfiguration class I suggested will only be
concerned with analyzer configuration, maybe it could be called
TextIndexAnalyzerConfiguration or something like that.
> Just a question about the usual worflow, who decides to integrate, or
not, a proposed code ?
The final decision is made by the core maintainers, often Andy Seaborne
(@afs). But I have tried to help along to make this ready (Andy actually asked
me for help as he was busy with the Jena3 transition) and I think other people
with an interest in jena-text could also give their opinion.
I think this is beginning to look like ready for merging - assuming the
changes discussed above will happen. When those are done I think it would make
sense to ask for final comments on the [email protected] mailing list, since
few people have commented here on GitHub but I know there are people like
myself on the list who make use of jena-text. The only controversial issue I
can think of right now is the parameter format for the text:query property
function - the "lang:xx" parameter looks a bit hacky to me, and while I can't
suggest anything else, somebody else might.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
