[ 
https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552742#comment-14552742
 ] 

ASF GitHub Bot commented on JENA-938:
-------------------------------------

Github user ajs6f commented on the pull request:

    https://github.com/apache/jena/pull/62#issuecomment-103971350
  
    No problemo. Because it was a single commit, it was no harder than a `git 
reset` to before that commit and then some tap dancing between `git add`ing 
changes, committing them and making PRs from the commits. 
    
    Does it seem reasonable to you to go forward to making some 
module-by-module PRs that remove unused `private` methods? Then people familiar 
with each module in question could decide whether the removed code was really 
dead or whether it has some potential future use. I would expect that at least 
some of it will be genuinely removable, right?


> Clean up dead code
> ------------------
>
>                 Key: JENA-938
>                 URL: https://issues.apache.org/jira/browse/JENA-938
>             Project: Apache Jena
>          Issue Type: Task
>          Components: Jena
>    Affects Versions: Jena 3.0.0
>            Reporter: A. Soroka
>            Priority: Minor
>              Labels: cleanup, jena
>
> This is an umbrella task to which several PRs will be attached, each 
> containing "clean up" for some modules in Jena. Each PR will contain only 
> non-controversial emendations, such as the removal of unused imports or 
> unthrown exceptions. Specifically disallowed are the removal of actual logic 
> or methods. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to