Github user osma commented on the pull request:
https://github.com/apache/jena/pull/64#issuecomment-105236007
@afs: I reviewed your [EntityDefinition
additions](https://github.com/apache/jena/commit/66a1eda82eeee2d8f551fac06d6b0a2672decdc2)
and they look fine to me. But should they be `@Deprecated`?
Alex's code also removes some methods from TextDatasetFactory. Should
compatibility methods (`@Deprecated` perhaps) be added back there as well?
Namely these:
```java
public static TextIndex createLuceneIndex(Directory directory,
EntityDefinition def, Analyzer queryAnalyzer)
public static Dataset createLucene(Dataset base, Directory directory,
EntityDefinition def, Analyzer queryAnalyzer)
public static DatasetGraph createLucene(DatasetGraph base, Directory
directory, EntityDefinition def, Analyzer queryAnalyzer)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
