Github user osma commented on the pull request:
https://github.com/apache/jena/pull/72#issuecomment-107341239
Thanks a lot Andy for your review! I will address your points soon and push
a new version.
Thank you also for pointing out Iter.map(), I actually wanted something
like that when coding but then I found Map1Iterator (which had been recently
upgraded to support Java 8 Functions) and settled on using that.
>I'm unsure whether it is better to add searchWithScore (or better name?),
which returns the List<TextHit> form, and retain search returning List<Node>
(just a Iter.map added each time):
I wouldn't call it searchWithScore - potentially, TextHit could also
contain other information than the node and score. searchWithHits?
searchForHits? searchTextHits?
I only use jena-text via SPARQL so I can't really tell whether the API
breakage would be bad. Maybe @amiara514 would have a comment as I understood he
is using jena-text via Java code? My opinion is slightly on the "clean up the
API with Jena3, don't worry about breakage" side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
