[
https://issues.apache.org/jira/browse/JENA-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14732110#comment-14732110
]
ASF GitHub Bot commented on JENA-1019:
--------------------------------------
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/92#issuecomment-138002455
The changes to what look like hand-written vocabularies look good.
Some of these files appear to have been autogenerated by schemagen (e.g the
ones where the model is `static private m_model` already).
1. As they are private, the compiler will treat them as "effectively final"
anyway.
1. The files may get overwritten.
> Shouldn't org.apache.jena.vocabulary.SKOS.m be final?
> -----------------------------------------------------
>
> Key: JENA-1019
> URL: https://issues.apache.org/jira/browse/JENA-1019
> Project: Apache Jena
> Issue Type: Bug
> Components: Core
> Affects Versions: Jena 3.0.0
> Reporter: Ramiro Pereira de Magalhães
> Priority: Minor
>
> In org.apache.jena.vocabulary.SKOS, the static member "m" is not final. Is it
> intentional? It seems to me that it should be a public static final value.
> Should the same be applied to classes DC_11.m_model, DCTerms.m_model, and
> other classes?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
