[ https://issues.apache.org/jira/browse/JENA-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022376#comment-15022376 ]
Andy Seaborne commented on JENA-1068: ------------------------------------- That's is (and was) OK for {{DatasetImpl}}. The code check {{getGraph}} each time - it was the Graph->Model step that was being cached and it isn't expensive like it was. {{DatasetGraphCaching}} would have been getting in the way. > Remove DatasetGraphCaching > -------------------------- > > Key: JENA-1068 > URL: https://issues.apache.org/jira/browse/JENA-1068 > Project: Apache Jena > Issue Type: Improvement > Components: ARQ, SDB > Affects Versions: Jena 3.0.0 > Reporter: Andy Seaborne > Assignee: Andy Seaborne > Priority: Minor > Fix For: Jena 3.0.1 > > > This class seems to do nothing much but does add complexity. There is > caching in {{DatasetImpl}} that competes with this caching. Nowadays, Jena's > storage systems are using {{GraphView}} which is very lightweight so caching > the creation of graphs is not beneficial and the cache has to be concurrent > and transaction safe. > The internal class {{DatasetGraphCaching.Helper}} is used only in SDB. > {{Helper}} could be moved to into SDB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)