On 25/11/15 12:02, A. Soroka wrote:
I think squashing is eliding the record, not changing the history,
but really I’m just asking for whatever policy does exist to be made
explicit so that people know what they are getting into when they try
to contribute.
Explaining the process was the point of my suggestion. Add also stuff
to explain copyright and headers.
Principles here: people matter, contributions matter. Code follows.
Squashing could delete evidence of a contributor. That changes
something that matters to the project and to ASF.
Changing anything between the contribution and when it hits ASF needs
very careful consideration. JIRA patches and users@, dev@ emails are
already on ASF hardware. Pulling into your local repo, to push to
/repos/asf/jena.git is not in the record until it gets to
/repos/asf/jena.git.
(and we should aim to merge PRs as-is if at all possible, because it
acknowledges the contributor in the git record)
Andy
--- A. Soroka The University of Virginia Library
On Nov 25, 2015, at 6:37 AM, Andy Seaborne <[email protected]>
wrote:
On 25/11/15 11:26, A. Soroka wrote:
committers might do various things like that before merging
Absolutely, no.
Do not rewrite the history, talk to the contributor.
Andy
