Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/106#discussion_r47353822
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/QuadTableForm.java ---
@@ -124,31 +96,21 @@ public PMapQuadTable get() {
return new PMapQuadTable(name()) {
@Override
- protected Quad quad(final Node s, final Node p,
final Node o, final Node g) {
- return Quad.create(g, s, p, o);
- }
+ public Quad tuple(final Quad q) {
+ return create(q.getSubject(), q.getPredicate(),
q.getObject(), q.getGraph());
--- End diff --
These criticisms are sadly accurate. I seem to have improved in one way by
creating other defects. I'm going to close this PR and see if I can solve the
problems I identified (repeated code, unclear responsibility) in a better,
tighter way, perhaps involving `ColumnMap`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
