[ https://issues.apache.org/jira/browse/JENA-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054644#comment-15054644 ]
Bruno P. Kinoshita commented on JENA-1087: ------------------------------------------ In this case it is probably just to remove warnings and to prevent issues in case fuseki ever gets deployed to a container that serializes servlets (as HttpServlet implements Serializable). But agree that in most containers like Tomcat, Jetty and JBoss, I have never heard about servlets being serialized, only HTTP Sessions in clustered containers. Would it be better to remove the serialVersionUID fields? > Fix minor code warnings such as deprecated methods, typos in comments and > missing serial version UID fields > ----------------------------------------------------------------------------------------------------------- > > Key: JENA-1087 > URL: https://issues.apache.org/jira/browse/JENA-1087 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki > Environment: Apache Maven 3.0.5 > Maven home: /usr/share/maven > Java version: 1.7.0_91, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre > Default locale: en_NZ, platform encoding: UTF-8 > OS name: "linux", version: "3.19.0-39-generic", arch: "amd64", family: "unix" > Ubuntu 14.04.3 LTS > Latest code from git repository. > Reporter: Bruno P. Kinoshita > Assignee: Bruno P. Kinoshita > Priority: Trivial > Labels: deprecated, javadoc, serialization, trivial, typo > Original Estimate: 2h > Remaining Estimate: 2h > > Reviewing Jena Fuseki 2 modules, there are few simple issues that could be > easily fixed, such as > * code using deprecated code, which comments suggest right alternatives (e.g. > DatasetGraphFactory.createGeneral() instead of > DatasetGraphFactory.createMem()) > * code that implements Serializable but without serialVersionUID > * typos in comments > * missing Javadocs > Will try to address this issue in simple commits, with clear explanation of > what was fixed, without changing code format or adding too many other > changes; which would make it harder to review the changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)