[
https://issues.apache.org/jira/browse/JENA-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235100#comment-15235100
]
ASF GitHub Bot commented on JENA-913:
-------------------------------------
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/134#issuecomment-208348383
I have applied this fix and pushed the result to branch "osgi-fix-init"
It builds with `mvn clean install` and because this fixes something that is
otherwise broken, it seems better to me to apply it to master in the current
state and then continue refining it if need be.
There are some changes and comment POM lines that it would be good to sort
out:
I'd like help with:
* checking it works in an OSGi environment.
* assessing `jena-osgi-test`
* Can we remove the `<Require-Capability>`? The
`JenaSubsystemRegistryBasic` has been changed.
* `<Embed-Dependency>` and `<Import-Package>` for Xerces. Jena uses
internal features of Xerces and is sentisite to the version (OK - it rarely
changes these days). Also, Xerces can be a endorsed jar making version
management by the app not work. Is it necessary to `Import` it?
The branch does not pass the tests in `jena-osgi-test`. Note that
`jena-osgi-test` is not in the build because of
[JENA-913](https://issues.apache.org/jira/browse/JENA-913) and
[JENA-1037](https://issues.apache.org/jira/browse/JENA-1037) so the test
failures are probably unrelated.
For the record: steps take to integrate the diff:
* Add license header to `Activator.java`
* De-tabbed the pom files and sorted out trailing white space.
* Some formatting "bit rot" had set in.
> jena-osgi-test breaks a build of Jena with "maven clean verify" starting with
> an empty repo.
> --------------------------------------------------------------------------------------------
>
> Key: JENA-913
> URL: https://issues.apache.org/jira/browse/JENA-913
> Project: Apache Jena
> Issue Type: Bug
> Components: OSGi
> Reporter: Andy Seaborne
>
> jena-osgi-test assumes that an "install" has been done of jena-osgi, either
> previously or in the current build.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
