Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/136#discussion_r60233218
--- Diff: jena-arq/src/main/java/org/apache/jena/riot/system/RiotLib.java
---
@@ -73,12 +78,37 @@ public static Node createIRIorBNode(String iri)
return NodeFactory.createURI(iri) ;
}
- /** Test whether */
- public static boolean isBNodeIRI(String iri)
- {
+ /** Test whether a IRI is a ARQ-encoded blank node. */
+ public static boolean isBNodeIRI(String iri) {
return skolomizedBNodes && iri.startsWith(bNodeLabelStart) ;
}
+ // These two must be in-step.
+ /** Function applied to undefined prefixes to convert to a URI string
*/
+ public static final Function<String,String> fixupPrefixes = (x)
-> "::"+x ;
--- End diff --
I'm probably missing something here, but it seems like this is only ever
used unwrapped, via `fixupPrefixes.apply`, and that's down below in this class
(where it is used instead of using `fixupPrefixIRI(String)`, but I'm not sure
why). Maybe it would be clearer to have an ordinary method and in future, if a
function is needed, to use a method reference?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
