Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/152#discussion_r70122439
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/graph/GraphOps.java
---
@@ -29,60 +29,49 @@
import org.apache.jena.sparql.core.Quad ;
// Combine with Jena GraphUtils.
-public class GraphOps
-{
-
- public static boolean containsGraph(DatasetGraph dsg, Node gn)
- {
- // [[DynDS]]
- if ( Quad.isDefaultGraph(gn))
+public class GraphOps {
+ public static boolean containsGraph(DatasetGraph dsg, Node gn) {
+ if ( Quad.isDefaultGraph(gn) )
return true ;
- if ( Quad.isUnionGraph(gn))
+ if ( Quad.isUnionGraph(gn) )
return true ;
return dsg.containsGraph(gn) ;
}
-
- public static Graph getGraph(DatasetGraph dsg, Node gn)
- {
- // [[DynDS]]
+
+ public static Graph getGraph(DatasetGraph dsg, Node gn) {
if ( gn == null )
return dsg.getDefaultGraph() ;
if ( Quad.isDefaultGraph(gn) )
// Explicit or generated.
return dsg.getDefaultGraph() ;
- if ( Quad.isUnionGraph(gn))
+ if ( Quad.isUnionGraph(gn) )
return unionGraph(dsg) ;
return dsg.getGraph(gn) ;
}
-
- public static Graph unionGraph(DatasetGraph dsg)
- {
+
+ public static Graph unionGraph(DatasetGraph dsg) {
+ // Snapshot it now.
--- End diff --
Yes, and it's just what was there before, though it does seem unlikely that
CCME happens and the alternative of a dynamic union makes sense as well.
I'll update the PR so there are two operations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
