[
https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369100#comment-15369100
]
ASF GitHub Bot commented on JENA-576:
-------------------------------------
Github user afs commented on the issue:
https://github.com/apache/jena/pull/151
I haven't got my head around the new API yet - this is just a preliminary
comment.
It is a bit of a change around authentication but I think it is the right
thing to do. It seems to me that the only other choice is not to migrate to
the new API which over time will become a nuisance.
Documenting the migration (for the release notes) will be helpful - maybe
an example for user/password in the HttpOp class javadoc. If someone can grok
that, they can see how to migrate their own code.
One thought - it looks like the new style is to treat `CloseableHttpClient`
as a one time use object. That means a try-resource in `HttpOp.exec`. I'm not
sure how widespread this is. `getDefaultHttpClient` `setDefaultHttpClient`
should be changed to be a `HttpClientBuilder`?
> Upgrade Apache HTTP Client to 4.3
> ---------------------------------
>
> Key: JENA-576
> URL: https://issues.apache.org/jira/browse/JENA-576
> Project: Apache Jena
> Issue Type: Dependency upgrade
> Components: ARQ
> Affects Versions: Jena 2.11.0
> Reporter: Rob Vesse
> Assignee: Rob Vesse
> Priority: Minor
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> As of 2.11.0 ARQ centralizes all HTTP operations through HttpOp which relies
> on Apache HTTP Client. Currently we are using 4.2.3 while the latest stable
> release is actually 4.3.1
> Therefore we should look at upgrading our code to use the latest version
> which may entail some refactoring since there appears to have been some
> breaking changes across the minor version bump which users have seen in usage
> - e.g.
> https://github.com/pyvandenbussche/sparqles/issues/9#issuecomment-27220738
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
