Github user ajs6f commented on a diff in the pull request:
...
     +  /**
     +      Count of the number of times this comparator has been called.
     +  */
     +  int count = 0;
     +  
     +  protected volatile boolean cancelled;
     --- End diff --

     Shouldn't this also be `volatile` for thread-safety?

Looks volatile to me?

Chris

--
"You've spotted a flaw in my thinking, Trev" Big Al,/The Beiderbeck Connection/

Epimorphics Ltd, http://www.epimorphics.com
Registered address: Court Lodge, 105 High Street, Portishead, Bristol BS20 6PT
Epimorphics Ltd. is a limited company registered in England (number 7016688)

Reply via email to