GitHub user osma opened a pull request:
https://github.com/apache/jena/pull/226
Refactor TextIndex and TextQueryPF in jena-text (preparation for JENA-1305)
In the development of JENA-1305 (Elasticsearch backend for jena-text) it
surfaced that the current division of labor between TextQueryPF and TextIndex
is awkward. The Lucene (or Solr) query string is mostly formed already on the
TextQueryPF side, which makes it difficult to implement a backend that uses a
different query language.
I have refactored the TextIndex interface, separating out the graph and
language information away from the query string into separate method
parameters, and changed the code in TextQueryPF and TextIndexLucene
correspondingly.
I'm opening this PR to ask for comments on the change. If there is no
opposition, I will merge it to master within a few days.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/osma/jena jena-1305-refactor-textindex
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #226
----
commit 4bb8a393efd670a38246a6e9788adf117a01155d
Author: Osma Suominen <[email protected]>
Date: 2017-03-13T15:42:48Z
fix warnings / remove dead code
commit 52f60589c59498cb7a7f52402f0515140952ab40
Author: Osma Suominen <[email protected]>
Date: 2017-03-13T15:55:34Z
JENA-1305: refactor TextIndex to take a separate graphURI parameter
commit 91eabe77d1e9414529a85598a6709cda54196d2a
Author: Osma Suominen <[email protected]>
Date: 2017-03-14T14:37:44Z
JENA-1305: refactor TextIndex so that lang is passed as a separate argument
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
