Github user osma commented on the issue:

    https://github.com/apache/jena/pull/227
  
    I think it would help the review if you rebased your branch on top of 
current apache master. Now it's hard to see what are your ES changes and what 
came from the included commits. Dropping Solr in particular caused large diffs 
and now all these commits mixed up in this PR.
    
    I haven't yet run the included tests. They don't seem to be run from `mvn 
test`. I would prefer tests that are automatically run from `mvn test`, since 
then they get tested in the CI builds, if that's possible. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to