[
https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927818#comment-15927818
]
ASF GitHub Bot commented on JENA-1305:
--------------------------------------
Github user osma commented on the issue:
https://github.com/apache/jena/pull/227
Hi @anujgandharv, thanks for the update, I will do a new review soon.
Regarding `TextIndex.get`, excellent question! I was actually wondering the
same when I did the review yesterday, but didn't take a closer look then. It
seems like this method is never called from within Jena! The only exception is
your TestTextIndexES class that specifically tests for this method.
I don't know what the reason for this method is. Maybe it was useful some
time ago, or maybe it was created for some purpose that never really
materialized. I think the `get` method could simply be removed from the
TextIndex interface and all implementations. I'm sorry that you had to spend
time implementing it.
The situation is similar for the `updateEntity` method. It is also not
called from Jena code and could be dropped.
> Elastic Search Support for Apache Jena Text
> --------------------------------------------
>
> Key: JENA-1305
> URL: https://issues.apache.org/jira/browse/JENA-1305
> Project: Apache Jena
> Issue Type: New Feature
> Components: Text
> Affects Versions: Jena 3.2.0
> Reporter: Anuj Kumar
> Assignee: Osma Suominen
> Labels: elasticsearch
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> This Jira tracks the development of Jena Text ElasticSearch Implementation.
> The goal is to extend Jena Text capability to index, at scale, in
> ElasticSearch. This implementation would be similar to the Lucene and Solr
> implementations.
> We will use ES version 5.2.1 for the implementation.
> The following functionalities would be supported:
> * Indexing Literal values
> * Updating indexed values
> * Deleting Indexed values
> * Custom Analyzer Support
> * Configuration using Assembler as well as Java techniques.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
