Github user osma commented on the issue:
https://github.com/apache/jena/pull/227
@anujgandharv Reading the documentation of the ES Maven plugin, no, I don't
think it's a wrapper around embedded Elasticsearch. Here is a project that
appears to use it: https://github.com/dadoonet/spring-elasticsearch
Regardless of how the tests are executed, I think we need tests for the
more difficult cases, such as removing one `Berlin` label but leaving others.
It is quite possible that bugs in the implementation will be discovered when
doing that. In any case, tests guard against subtle changes further down the
line, when jena-text is updated, the Elasticsearch dependency is upgraded to a
new version etc.
Thanks for incorporating the comments. I will do a new review of the code
and take a closer look at the current tests.
I think this is looking very close to merging. Do others have comments on
the code? @ajs6f? @afs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
