[ 
https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945280#comment-15945280
 ] 

ASF GitHub Bot commented on JENA-1305:
--------------------------------------

Github user ajs6f commented on a diff in the pull request:

    https://github.com/apache/jena/pull/227#discussion_r108439061
  
    --- Diff: 
jena-text/src/test/java/org/apache/jena/query/text/it/BaseESTest.java ---
    @@ -0,0 +1,111 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.jena.query.text.it;
    +
    +import org.apache.jena.query.text.EntityDefinition;
    +import org.apache.jena.query.text.TextIndexConfig;
    +import org.apache.jena.query.text.TextIndexES;
    +import org.apache.jena.vocabulary.RDFS;
    +import org.elasticsearch.action.admin.indices.delete.DeleteIndexRequest;
    +import 
org.elasticsearch.action.admin.indices.exists.indices.IndicesExistsRequest;
    +import org.elasticsearch.client.transport.TransportClient;
    +import org.elasticsearch.common.settings.Settings;
    +import org.elasticsearch.common.transport.InetSocketTransportAddress;
    +import org.elasticsearch.transport.client.PreBuiltTransportClient;
    +import org.junit.After;
    +import org.junit.Assert;
    +import org.junit.Before;
    +import org.junit.BeforeClass;
    +
    +import java.net.InetAddress;
    +import java.net.UnknownHostException;
    +
    +/**
    + * Base Class for ElasticSearch based Integration tests.
    + */
    +public abstract class BaseESTest {
    +
    +    protected static TransportClient transportClient;
    +
    +    private final static String ADDRESS = "127.0.0.1";
    +    private final static int PORT = 9500;
    +    private final static String CLUSTER_NAME = "elasticsearch";
    +    protected final static String INDEX_NAME = "jena-text";
    +
    +    protected static TextIndexES classToTest;
    +
    +    static final String DOC_TYPE = "text";
    +
    +    /**
    +     * Make sure that we have connectivity to the locally running ES node.
    +     * The ES is started during the pre-integration-test phase
    +     */
    +    @BeforeClass
    +    public static void setupTransportClient() {
    +
    +        Settings settings = Settings.builder().put("cluster.name", 
CLUSTER_NAME).build();
    +        transportClient = new PreBuiltTransportClient(settings);
    +        try {
    +            transportClient.addTransportAddress(
    +                    new 
InetSocketTransportAddress(InetAddress.getByName(ADDRESS), PORT)
    +            );
    +        } catch (UnknownHostException ex) {
    +            Assert.fail("Failed to create transport client" + 
ex.getMessage());
    +        }
    +        classToTest = new TextIndexES(config(), transportClient, 
INDEX_NAME);
    +        Assert.assertNotNull("Transport client was not created 
successfully", transportClient);
    +
    +
    +    }
    +
    +    /**
    +     * Make sure that we always start we a clean index.
    +     * This will help keep the tests isolated
    +     * @throws Exception
    +     */
    +    @Before
    --- End diff --
    
    As a future note, rather than manually setting-up and clearing-out 
resources like this, we could use a JUnit  `@Rule`  `ExternalResource` for 
concision, clarity, and easier reuse.


> Elastic Search Support for Apache Jena Text 
> --------------------------------------------
>
>                 Key: JENA-1305
>                 URL: https://issues.apache.org/jira/browse/JENA-1305
>             Project: Apache Jena
>          Issue Type: New Feature
>          Components: Text
>    Affects Versions: Jena 3.2.0
>            Reporter: Anuj Kumar
>            Assignee: Osma Suominen
>              Labels: elasticsearch
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> This Jira tracks the development of Jena Text ElasticSearch Implementation.
> The goal is to extend Jena Text capability to index, at scale, in 
> ElasticSearch. This implementation would be similar to the Lucene and Solr 
> implementations.
> We will use ES version 5.2.1 for the implementation.
> The following functionalities would be supported:
> * Indexing Literal values
> * Updating indexed values
> * Deleting Indexed values
> * Custom Analyzer Support
> * Configuration using Assembler as well as Java techniques.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to