[ 
https://issues.apache.org/jira/browse/JENA-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957088#comment-15957088
 ] 

Marco Brandizi edited comment on JENA-1297 at 4/5/17 3:49 PM:
--------------------------------------------------------------

[~ajs6f] I use this approach to factorise similar cases: 
https://github.com/EBIBioSamples/biosd2rdf/blob/master/src/main/assembly/resources/ebi_deploy/virtuoso/deploy.sh

_get_ver.sh contains stuff common to several scripts. it needs to be invoked 
via 'source' ('.' is a shorthand), else it's invoked as a sub-shell and its 
environment lost when flow returns to the caller.

An alternative approach is to have scripts with placeholders and instantiate 
the placeholders at build time (but the former one should be simpler).



was (Author: zakmck):
[~ajs6f] I use this approach to factorise similar cases: 
https://github.com/EBIBioSamples/biosd2rdf/blob/master/src/main/assembly/resources/ebi_deploy/virtuoso/deploy.sh

_get_ver.sh contains stuff common to several scripts. it needs to be invoked 
via 'source' ('.' is a shorthand), else it's invoked as a sub-shell and its 
environment lost when finished.

An alternative approach is to have scripts with placeholders and instantiate 
the placeholders at build time (but the former one should be simpler).


> Code to set JENA_HOME in scripts doesn't work (links)
> -----------------------------------------------------
>
>                 Key: JENA-1297
>                 URL: https://issues.apache.org/jira/browse/JENA-1297
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: Cmd line tools
>    Affects Versions: Jena 3.2.0
>         Environment: OS X 10.11.6 (15G1217). Java 1.8.0_92
>            Reporter: Marco Brandizi
>            Assignee: A. Soroka
>
> I'm trying the script bin/sparql, to me the code that deals with links when 
> setting JENA_HOME is unnecessary, it ends up setting '.' as the prefix for 
> lib/ ad triggering main class not found (when putting $JENA_HOME/bin in PATH).
> The same script works when I set JENA_HOME with the physical path of Jena, 
> not its symlink (which I don't like, because I prefer to upgrade by 
> symlinking the last version to 'jena' and not having to change anything else).
> I've tried a version of such script where I removed all if [ -L ... ]  and it 
> works perfectly well. In my opinion, the existing code (using dirname ... && 
> pwd) is enough to track the folder where the script is.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to