[ 
https://issues.apache.org/jira/browse/JENA-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971103#comment-15971103
 ] 

ASF GitHub Bot commented on JENA-1321:
--------------------------------------

GitHub user ajs6f opened a pull request:

    https://github.com/apache/jena/pull/241

    JENA-1321: Exception rewrapping in HttpQuery masks error response from the 
server

    It's a bit odd-feeling to couple `HttpException` so tightly, but given that 
it is an Atlas type, I don't feel terrible about it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajs6f/jena JENA-1321

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #241
    
----
commit 2a8257d0ef0799464d1f09f6badc9e7bf50c48fd
Author: ajs6f <[email protected]>
Date:   2017-04-17T14:21:34Z

    JENA-1321: Exception rewrapping in HttpQuery masks error response from the 
server

----


> Exception rewrapping in HttpQuery masks error response from the server
> ----------------------------------------------------------------------
>
>                 Key: JENA-1321
>                 URL: https://issues.apache.org/jira/browse/JENA-1321
>             Project: Apache Jena
>          Issue Type: Improvement
>          Components: ARQ
>    Affects Versions: Jena 3.2.0
>         Environment: Client: Grails 3.2.8, Windows 7
> Server: Oracle Joseki server on Tomcat 8 (RHEL)
>            Reporter: Russell Morrisey
>            Assignee: A. Soroka
>   Original Estimate: 20m
>  Remaining Estimate: 20m
>
> When the SPARQL server responds to a request with an error (e.g. 500 error), 
> the Tomcat error response body provides detailed information about what went 
> wrong. This response information is included in the underyling HttpException, 
> but is being masked by faulty error handling code in 
> org.apache.jena.sparql.engine.http.HttpQuery.
> The rewrap() method should specify httpEx as the root cause of the exception, 
> not httpEx.getCause(). This will ensure that the response body information is 
> preserved.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to