[
https://issues.apache.org/jira/browse/JENA-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978755#comment-15978755
]
ASF GitHub Bot commented on JENA-1320:
--------------------------------------
GitHub user ehedgehog opened a pull request:
https://github.com/apache/jena/pull/244
Open iterators reported when cancelling a query during sorting
As per JENA-1320. When cancellations in QueryIterSort and QueryIterTopN
occur
at the wrong moment, the source iterators (the ones being consumed by Sort
or TopN) are not closed in the usual way but only by the QueryIteratorCheck
check.
This fix adds additional calls to close() and closeIterator() so that then
usual (non-cancel) paths close the source iterators, and adds extra
handling of the QueryCancelledException so that when it is thrown
through these classes the source iteratots are close(d).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/epimorphics/jena cancel-sort-cj
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/244.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #244
----
commit b289446ef53f1f4f5ef56cebd235bc1eb830d4ec
Author: Chris Dollin <[email protected]>
Date: 2017-03-14T15:45:33Z
Merge pull request #3 from apache/master
update from upstream
commit 88e6811552cff567a486bfb0863bed8689ae4a49
Author: Chris Dollin <[email protected]>
Date: 2017-04-04T14:31:57Z
Merge pull request #4 from apache/master
sync from original
commit 61e891752b12e842d888d48780fb324002853eb9
Author: Chris Dollin <[email protected]>
Date: 2017-04-06T07:42:39Z
Merge pull request #5 from apache/master
synching with apache/jena
commit 6989f2ff591981cccae59789636cb2401070368d
Author: Chris Dollin <[email protected]>
Date: 2017-04-19T10:46:32Z
Merge pull request #6 from apache/master
update from original
commit 2fe3c281aa55605552e66cae8ac1484072c1944a
Author: Chris Dollin <[email protected]>
Date: 2017-04-20T13:53:01Z
Added some tests for close() on QueryIterSort ad QueryIterTopN.
----
> Open iterators reported when cancelling a query during sorting
> --------------------------------------------------------------
>
> Key: JENA-1320
> URL: https://issues.apache.org/jira/browse/JENA-1320
> Project: Apache Jena
> Issue Type: Bug
> Components: ARQ
> Affects Versions: Jena 3.2.0
> Reporter: Andy Seaborne
>
> "Bug in SortedDataBag?"
> https://lists.apache.org/thread.html/be3ecf8f41b03a747f6bab78a072ca55b2ea1a07a6d7ae1e53600ac5@%3Cdev.jena.apache.org%3E
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
