[
https://issues.apache.org/jira/browse/JENA-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989177#comment-15989177
]
ASF GitHub Bot commented on JENA-1329:
--------------------------------------
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/248
JENA-1329: Define and use QueryIterator.isJoinIdentity.
Don't test for class `QueryIterRoot`.
Don't use `QueryIterRoot` to hold a binding with set variables.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena query-root-iterator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #248
----
commit c590289cd784d72eacbc11bf3129664aaad8b27f
Author: Andy Seaborne <[email protected]>
Date: 2017-04-26T10:43:44Z
JENA-1329: Define and use QueryIterator.isJoinIdentity.
Don't test for QueryIterRoot.
Don't use QueryIterRoot to hold a binding with set variables.
----
> QueryIterRoot should not be overloaded for initial bindings.
> ------------------------------------------------------------
>
> Key: JENA-1329
> URL: https://issues.apache.org/jira/browse/JENA-1329
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ
> Affects Versions: Jena 3.2.0, Jena 3.3.0
> Reporter: Andy Seaborne
> Assignee: Andy Seaborne
>
> {{QueryIterRoot}} is also used for initial bindings but the code sometimes
> assumes that the root binding is the join identity iterator (one row, no
> columns).
> {{QueryIterRoot}} should be reserved for for this case.
> {{QueryIterator}} could have a method {{.isJoinIdentity()}} so that an
> iterator can be tested without peeking and without assuming the java class.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
