Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/237#discussion_r116365929 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java --- @@ -978,7 +967,6 @@ public boolean isDayTimeDuration() public boolean getBoolean() { raise(new ExprEvalTypeException("Not a boolean: "+this)) ; return false ; } public String getString() { raise(new ExprEvalTypeException("Not a string: "+this)) ; return null ; } public String getLang() { raise(new ExprEvalTypeException("Not a string: "+this)) ; return null ; } - public String getCollation() { raise(new ExprEvalTypeException("Not a sort key: "+this)) ; return null ; } --- End diff -- This would be the "value" of a NodeValueSortKey ... which is itself so NodeValueSortKey then the casts aren't needed in the comparision.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---