[
https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270909#comment-16270909
]
ASF GitHub Bot commented on JENA-1430:
--------------------------------------
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/314#discussion_r153813914
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java
---
@@ -26,25 +30,29 @@
import org.apache.jena.atlas.logging.Log ;
import org.apache.jena.query.Dataset ;
import org.apache.jena.query.DatasetFactory ;
-import org.apache.jena.rdf.model.Model ;
-import org.apache.jena.rdf.model.RDFNode ;
-import org.apache.jena.rdf.model.Resource ;
+import org.apache.jena.rdf.model.*;
import org.apache.jena.sparql.graph.GraphFactory ;
import org.apache.jena.sparql.util.FmtUtils ;
import org.apache.jena.sparql.util.graph.GraphUtils ;
+import org.apache.jena.system.Txn;
public class DatasetAssembler extends AssemblerBase implements Assembler {
public static Resource getType() {
return DatasetAssemblerVocab.tDataset ;
}
@Override
- public Object open(Assembler a, Resource root, Mode mode) {
+ public Dataset open(Assembler a, Resource root, Mode mode) {
Dataset ds = createDataset(a, root, mode) ;
return ds ;
}
public Dataset createDataset(Assembler a, Resource root, Mode mode) {
+ checkType(root, DatasetAssemblerVocab.tDataset);
+ // use TIM if quads are loaded or if all named Graphs are loaded
via data property
+ final boolean allNamedGraphsLoadViaData = multiValueResource(root,
pNamedGraph).stream().allMatch(g -> g.hasProperty(data));
--- End diff --
i don't understand the comment-- are you suggesting to use SPARQL instead
of the API? If we are missing a test here, it means that I did not understand
your plan for how to "distribute" the predicates amongst the types of dataset.
In fact, I'm starting to wonder if that's what we should do after all, or
whether it would be better to deprecate some of them, since they overlap, or
confine the meanings of those that overlap so that they don't...
> Quad loading for in-memory assemblers
> -------------------------------------
>
> Key: JENA-1430
> URL: https://issues.apache.org/jira/browse/JENA-1430
> Project: Apache Jena
> Issue Type: Bug
> Components: ARQ
> Reporter: A. Soroka
> Assignee: A. Soroka
>
> In-memory dataset Assemblers should support loading quad files.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
