Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/314#discussion_r153815022
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java
---
@@ -20,54 +20,45 @@
import static org.apache.jena.assembler.JA.data;
import static org.apache.jena.query.DatasetFactory.createTxnMem;
-import static org.apache.jena.query.ReadWrite.WRITE;
import static org.apache.jena.riot.RDFDataMgr.read;
import static
org.apache.jena.sparql.core.assembler.AssemblerUtils.setContext;
-import static
org.apache.jena.sparql.core.assembler.DatasetAssemblerVocab.pGraphName;
-import static
org.apache.jena.sparql.core.assembler.DatasetAssemblerVocab.pNamedGraph;
-import static
org.apache.jena.sparql.util.graph.GraphUtils.getAsStringValue;
-import static
org.apache.jena.sparql.util.graph.GraphUtils.multiValueResource;
+import static
org.apache.jena.sparql.core.assembler.DatasetAssemblerVocab.*;
+import static org.apache.jena.sparql.util.graph.GraphUtils.*;
import org.apache.jena.assembler.Assembler;
import org.apache.jena.assembler.Mode;
-import org.apache.jena.assembler.assemblers.AssemblerBase;
import org.apache.jena.query.Dataset;
import org.apache.jena.rdf.model.Resource;
+import org.apache.jena.system.Txn;
/**
* An {@link Assembler} that creates in-memory {@link Dataset}s.
*/
-public class InMemDatasetAssembler extends AssemblerBase implements
Assembler {
+public class InMemDatasetAssembler extends DatasetAssembler {
public static Resource getType() {
- return DatasetAssemblerVocab.tDatasetTxnMem ;
+ return DatasetAssemblerVocab.tMemoryDataset ;
}
@Override
public Dataset open(final Assembler assembler, final Resource root,
final Mode mode) {
- checkType(root, DatasetAssemblerVocab.tDatasetTxnMem);
--- End diff --
One of my frustrations with this is that there were no tests of these
assemblers at all when I started, so I'm not very sure about the current
expected/guaranteed behavior. WRT to our comments above about the use of
predicates, should we start migrating people away from `ja:graph`, or (probably
better) instead restricting `ja:data` to _only_ loading quads into a dataset?
---
