Github user ajs6f commented on a diff in the pull request:

    https://github.com/apache/jena/pull/333#discussion_r158256408
  
    --- Diff: 
jena-arq/src/test/java/org/apache/jena/sparql/core/AbstractTestDataset.java ---
    @@ -116,4 +116,24 @@
             ds.addNamedModel(graphName, model1) ;
             assertFalse("Dataset should not be empty after a named graph has 
been added!", ds.isEmpty());
         }
    +    
    +    @Test public void dataset_07()
    +    {
    +        String graphName = "http://example/"; ;
    +        Dataset ds = createDataset() ;
    +        ds.addNamedModel(graphName, model1) ;
    +        assertTrue("Named graph not found", 
ds.containsNamedModel(graphName));
    +    }
    +    
    +    // Even if empty, union and named default graph exist (sort of).
    +
    +    @Test public void dataset_08() {
    +        Dataset ds = createDataset();
    +        assertTrue("Union named graph not found", 
ds.containsNamedModel(Quad.unionGraph.getURI()));
    +    }
    +
    +    @Test public void dataset_09() {
    +        Dataset ds = createDataset();
    +        assertTrue("Named default graph not found", 
ds.containsNamedModel(Quad.defaultGraphIRI.getURI()));
    --- End diff --
    
    This message seems a little confusing to me (`Named default graph`), maybe:
    ```
    Default graph not found under its URI ( "+Quad.defaultGraphIRI.getURI()+" )"
    ```
    is verbose, but very clear.


---

Reply via email to