Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/372#discussion_r172582451
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/lang/BlankNodeAllocatorGlobal.java
---
@@ -18,41 +18,39 @@
package org.apache.jena.riot.lang;
-import java.util.HashMap ;
-import java.util.Map ;
+import java.util.HashMap;
+import java.util.Map;
-import org.apache.jena.graph.Node ;
-import org.apache.jena.graph.NodeFactory ;
+import org.apache.jena.graph.Node;
+import org.apache.jena.graph.NodeFactory;
-/** Allocate blank nodes by creating a randomly generated blank node.
- * This allocator has arbitrary sized state.
+/**
+ * Allocate blank nodes by creating a randomly generated blank node.
+ * This allocator has arbitrary sized internal state needed to record
+ * the label to node mapping.
*/
public class BlankNodeAllocatorGlobal implements BlankNodeAllocator
{
- Map<String, Node> map = new HashMap<>() ;
+ Map<String, Node> map = new HashMap<>();
public BlankNodeAllocatorGlobal() {}
@Override
- public void reset() { map.clear() ; }
+ public void reset() { map.clear(); }
@Override
- public Node alloc(String label)
- {
- Node b = map.get(label) ;
- if ( b == null )
- {
- b = create() ;
- map.put(label, b) ;
+ public Node alloc(String label) {
+ Node b = map.get(label);
--- End diff --
Maybe just `return map.computeIfAbsent(x->create())`?
---
