[ 
https://issues.apache.org/jira/browse/JENA-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403924#comment-16403924
 ] 

ASF GitHub Bot commented on JENA-1488:
--------------------------------------

Github user kinow commented on the issue:

    https://github.com/apache/jena/pull/385
  
    +1 @rvesse comments. And +1 for the great PR @xristy !!! Tested with the 
WIP `SelectiveFoldingFilter` for JENA-1488, and it worked like a charm!!!!! 
:tada: :tada: :tada: 
    
    First created a normal JenaText configuration, and everything worked with 
no issues. Then replaced my `analyzer` by a `DefinedAnalyzer`... had a few 
hiccups forgetting to create a tokenizer, and had to update the filter to use a 
`CharArraySet` (much better that way I think).
    
    But in the end got the query working as expected. Confirmed with Luke that 
the contents were indexed correctly with the new filter... did a quick search 
in Luke, then used Fuseki, and everything worked as expected.
    
    Once this one is merged, we'll be ready for another PR for JENA-1488. In 
the meantime, I will start working on documentation and tests !
    
    Thanks!
    Bruno


> SelectiveFoldingFilter for jena-text
> ------------------------------------
>
>                 Key: JENA-1488
>                 URL: https://issues.apache.org/jira/browse/JENA-1488
>             Project: Apache Jena
>          Issue Type: Improvement
>          Components: Text
>    Affects Versions: Jena 3.6.0
>            Reporter: Osma Suominen
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>
> Currently there's some support for accent folding in jena-text, because 
> Lucene provides an ASCIIFoldingFilter. When this filter is enabled, a search 
> for "deja vu" will match the literal "déjà vu" in the data.
> But we can't use it here at the National Library of Finland (for Finto.fi / 
> Skosmos), because it folds too much! In the Finnish alphabet, in addition to 
> the Latin a-z (which are in ASCII) we use the letters åäö and these should 
> not be folded to ASCII. So we need a Lucene analyzer that can be configured 
> with an exclude list, something like 
>  
> new SelectiveFoldingFilter(String excludeChars) 
>  
> and that can be also be configured via the Jena assembler just like other 
> analyzers supported by jena-text. 
>  
> This was also briefly discussed on the skosmos-users mailing list: 
> [https://groups.google.com/d/msg/skosmos-users/x3zR_uRBQT0/Q90-O_iDAQAJ] 
> Apparently Norwegians have the same problem...
> I've discussed this with [~kinow] and he has some initial code to implement 
> this feature, so I think we can turn this into a PR fairly soon.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to