Github user rvesse commented on a diff in the pull request:

    https://github.com/apache/jena/pull/391#discussion_r179407258
  
    --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/lib/NodeLib.java ---
    @@ -53,26 +52,32 @@
         // Characters in IRIs that are illegal and cause SSE problems, but we 
wish to keep.
         final private static char MarkerChar = '_' ;
         final private static char[] invalidIRIChars = { MarkerChar , ' ' } ; 
    +    final private static int SIZE = 1024;
    +    // Marshalling space.
    +    final private static  ByteBuffer workspace = ByteBuffer.allocate(SIZE);
    --- End diff --
    
    This buffer is a `static` and there is no thread safety or synchronisation 
around its usage.  Is this safe?


---

Reply via email to