[
https://issues.apache.org/jira/browse/JENA-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437319#comment-16437319
]
ASF GitHub Bot commented on JENA-1521:
--------------------------------------
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/397
TDB2 tidyup
Including JENA-1521 (TDB1 and TDB2 close).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena tdb2-tidyup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/397.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #397
----
commit 32608d250fa60788b53db71b79d904fb63dbdd88
Author: Andy Seaborne <andy@...>
Date: 2018-04-13T12:59:35Z
Add TDB2Factory.assembleDataset. Remove out of date comments.
commit f6d3c77f32e5ba8c48d2b987dea3915004970eab
Author: Andy Seaborne <andy@...>
Date: 2018-04-13T13:04:55Z
JENA-1521: Don't close. TDB1 and TDB2 datasets are managed differently.
commit 246786abfb60f2908bce52772cd40771ba2a206d
Author: Andy Seaborne <andy@...>
Date: 2018-04-13T13:05:16Z
Remove deprecated DatasetGraphWithLock.
commit 67b18af43f54814f66f63c13866556b4256e459c
Author: Andy Seaborne <andy@...>
Date: 2018-04-13T13:31:51Z
JENA-1521: Only really close if non-transactional
commit d65e0ae630911cf1665cbd354d928765d16491ce
Author: Andy Seaborne <andy@...>
Date: 2018-04-13T13:43:53Z
Remove stray local/
----
> TDB2 backed Datasets cannot be re-opened.
> -----------------------------------------
>
> Key: JENA-1521
> URL: https://issues.apache.org/jira/browse/JENA-1521
> Project: Apache Jena
> Issue Type: Bug
> Environment: Apache Jena: 3.7.0
> Java: 1.8_162
> Reporter: Greg Albiston
> Priority: Major
>
> If a Dataset connected to with TDB2Factory.connectDataset() is opened, closed
> and then later re-opened it is reported that the Dataset is closed.
> Opening, closing and re-opening a Dataset with TDBFactory.createDataset()
> causes no issues.
> Example code to reproduce:
> {noformat}
> public void testTDB2OpenClose() {
> System.out.println("TDB2 Open Close");
> try {
> Dataset dataset = TDB2Factory.connectDataset("test_tdb2");
> dataset.begin(ReadWrite.WRITE);
> Model defaultModel = dataset.getDefaultModel();
>
> defaultModel.add(ResourceFactory.createResource("http://example.org/my#SubjA";),
> ResourceFactory.createProperty("http://example.org/my#PropA";),
> ResourceFactory.createResource("http://example.org/my#ObjA";));
> dataset.commit();
> dataset.end();
> dataset.close();
> Dataset dataset2 = TDB2Factory.connectDataset("test_tdb2");
> dataset2.begin(ReadWrite.READ);
> Model readModel = dataset2.getDefaultModel();
> Iterator<Statement> statements = readModel.listStatements();
> while (statements.hasNext())
> { Statement statement = statements.next(); System.out.println(statement); }
> dataset2.end();
> dataset2.close();
> } catch (Exception ex) \{ System.out.println("Exception: " +
> ex.getMessage()); }
> }
> {noformat}
> {noformat}
> public void testTDB1OpenClose() {
>
> System.out.println("TDB1 Open Close");
> try {
> Dataset dataset = TDBFactory.createDataset("test_tdb1");
> dataset.begin(ReadWrite.WRITE);
> Model defaultModel = dataset.getDefaultModel();
>
> defaultModel.add(ResourceFactory.createResource("http://example.org/my#SubjA";),
> ResourceFactory.createProperty("http://example.org/my#PropA";),
> ResourceFactory.createResource("http://example.org/my#ObjA";));
> dataset.commit();
> dataset.end();
> dataset.close();
>
> Dataset dataset2 = TDBFactory.createDataset("test_tdb1");
> dataset2.begin(ReadWrite.READ);
> Model readModel = dataset2.getDefaultModel();
> Iterator<Statement> statements = readModel.listStatements();
> while (statements.hasNext()) \{ Statement statement = statements.next();
> System.out.println(statement); }
> dataset2.end();
> dataset2.close();
> } catch (Exception ex)
> { System.out.println("Exception: " + ex.getMessage()); }
> }
> {noformat}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
