[
https://issues.apache.org/jira/browse/JENA-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439729#comment-16439729
]
ASF GitHub Bot commented on JENA-1525:
--------------------------------------
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/400#discussion_r181818306
--- Diff: jena-db/pom.xml ---
@@ -75,6 +79,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
+ <configuration>
+ <archive>
+ <manifestEntries>
+
<Automatic-Module-Name>${automatic.module.name}</Automatic-Module-Name>
--- End diff --
My knowledge of JPMS is a bit weak. This module (jena-db) is a POM. This
means that Automatic-Module-Name with this setting will apply to all the jars
underneath this module (the jena-db-* modules) with the same name.
If a number of jars have the same Automatic-Module-Name, are they in the
same module? (which would be convenient).
Otherwise, I can fix up the submodules when merging it. No need to round
again.
> Add <Automatic-Module-Name> to <manifestEntries> for each jar module.
> ---------------------------------------------------------------------
>
> Key: JENA-1525
> URL: https://issues.apache.org/jira/browse/JENA-1525
> Project: Apache Jena
> Issue Type: Improvement
> Reporter: Andy Seaborne
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
